new singular quadrature routine#24
Merged
luca-heltai merged 4 commits intoJan 16, 2018
Merged
Conversation
luca-heltai
reviewed
Jan 11, 2018
| // (QGaussOneOverR<dim-1>(singular_quadrature_order, | ||
| // fe->get_unit_support_points()[i],true)); | ||
| } | ||
| sing_quadratures[i] = get_singular_quadrature(i); |
Contributor
There was a problem hiding this comment.
Why do you create a new vector here? Since you create it as a static vector in the get_singular_quadrature function, there is no need to copy it back here.
Contributor
There was a problem hiding this comment.
just call get_singular_quadrature(i) when you need it, instead of sing_quadratures[i]
Contributor
|
indent. |
luca-heltai
requested changes
Jan 15, 2018
| singular_quadrature | ||
| = dynamic_cast<Quadrature<dim-1>*>( | ||
| &sing_quadratures[singular_index]); | ||
| &(get_singular_quadrature[singular_index])); |
Contributor
There was a problem hiding this comment.
this is a function. It cannot work this way. replace [] with ()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated the singular quadrature procedure and introduced the new QSplit formulas for BEM in 3D