Conversation
setup.py: builtin/image.py directly imports wordcloud but that is not in setup.py
Not sure why this wasn't seen before. Maybe some other package pulls it
it in implicity? However if it is imported here, it should be mentioned
in setup.py
mathics/builtin/image.py: now that from_python distinguishs ints from
bools image data needs to be converted to an "int" not a "bool".
Otherwise, we get:
1867 ( 4): TEST ImageData[Image[{{0, 1}, {1, 0}, {1, 1}}], "Bit"]
Test failed: ImageData in Reference of Built-in Symbols / Image[] and image related functions.
ImageData[Image[{{0, 1}, {1, 0}, {1, 1}}], "Bit"]
Result: {{False, True}, {True, False}, {True, True}}
Wanted: {{0, 1}, {1, 0}, {1, 1}}
Previously it was required on OSX only. Image tests now seem to require it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup.py: builtin/image.py directly imports wordcloud but that is not in setup.py
Not sure why this wasn't seen before. Maybe some other package pulls it
it in implicity? However if it is imported here, it should be mentioned
in setup.py
mathics/builtin/image.py: now that from_python distinguishs ints from
bools image data needs to be converted to an "int" not a "bool".
Otherwise, we get:
1867 ( 4): TEST ImageData[Image[{{0, 1}, {1, 0}, {1, 1}}], "Bit"]
Test failed: ImageData in Reference of Built-in Symbols / Image[] and image related functions.
ImageData[Image[{{0, 1}, {1, 0}, {1, 1}}], "Bit"]
Result: {{False, True}, {True, False}, {True, True}}
Wanted: {{0, 1}, {1, 0}, {1, 1}}