Implementing Compile for non compilable llvmlite functions as python functions#1161
Merged
Implementing Compile for non compilable llvmlite functions as python functions#1161
Conversation
rocky
approved these changes
Mar 14, 2021
Member
rocky
left a comment
rocky
left a comment
There was a problem hiding this comment.
LGTM - thanks for doing this!
I took the liberty of rebasing off of master (there were merge conflicts) and squashed some commits.
and address some merge conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, some ideas to improve the support of
System`Compileare implemented, in a way more generic expressions can be converted to a python callable object, including complex valued functions.This mechanism is also used to implement a better behaviour for to_python over
System`Functionexpressions: when called on these kind of expressions, to_python returns a python callable object which can be passed to things like optimizers and integrators.