Conversation
Contributor
Author
|
Now, this also fixes #1171. |
* Add # noqa to the __version__ import * Remove #!/usr/bin/env python3 which is wrong here * Remove unused imports in buitins
* Add # noqa to the __version__ import * Remove #!/usr/bin/env python3 which is wrong here * Remove unused imports in buitins
rocky
force-pushed
the
sanitizeloadmodules
branch
from
cc7e054 to
7138976
Compare
rocky
approved these changes
Mar 6, 2021
Member
rocky
left a comment
rocky
left a comment
There was a problem hiding this comment.
I tried this locally and it looked good.
About the import line. I added a # noqa See https://stackoverflow.com/questions/45346575/what-does-noqa-mean-in-python-comments
Also I ran black over the files and removed the lines that start:
#/usr/bin/env python3
which is not appropriate here. These belong only on command-line files.
@mmatera I had originally wanted to keep this separate but there were just all these conflicts when creating the branch. Also this change is a bit more than I would have liked.
Please check it over and if ok merge in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, I try to detect problems associated with version mismatch (See #1169 for an example).