Merged
Conversation
rocky
reviewed
Mar 8, 2021
|
|
||
| def boxes_to_text(self, **options) -> str: | ||
| return '"' + base64.b64encode(self.value).decode('utf8') + '"' | ||
| return '"' + self.__str__() + '"' |
Member
There was a problem hiding this comment.
Note: think self.__str()__ is the same thing as str(self).
Contributor
Author
There was a problem hiding this comment.
Indeed, self.__str__() and str(self) should be the same thing with a different number of keystrokes. I thought this way was more "explicit", but as you prefer...
Member
There was a problem hiding this comment.
It was just an observation. Do any way you wish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix some issues of the current implementation of ByteArray, and covers new functionalities like conversions to Normal List objects.