Skip to content

Improve Expand and ExpandAll rebase (from builtin-submodules)#1335

Merged
rocky merged 2 commits intomasterfrom
improveexpand-rebase
May 3, 2021
Merged

Improve Expand and ExpandAll rebase (from builtin-submodules)#1335
rocky merged 2 commits intomasterfrom
improveexpand-rebase

Conversation

@rocky
Copy link
Copy Markdown
Member

@rocky rocky commented May 1, 2021

Fixes #1301 but rebased on builtin-submodules #1316

@rocky rocky requested a review from mmatera May 1, 2021 05:24
@rocky rocky changed the base branch from master to builtin-submodules May 1, 2021 05:25
@rocky rocky changed the title Improveexpand rebase Imrove Expand and ExpandAll rebase (from builtin-submodules) May 1, 2021
#> (y^2)^(1/2)/(2x+2y)//Expand
= Sqrt[y ^ 2] / (2 x + 2 y)

## This caused a program crash!
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmatera Do we still want this comment?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think so, since it pass the test...

@rocky rocky changed the title Imrove Expand and ExpandAll rebase (from builtin-submodules) Improve Expand and ExpandAll rebase (from builtin-submodules) May 1, 2021
@rocky rocky changed the base branch from builtin-submodules to master May 1, 2021 11:43
Copy link
Copy Markdown
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready for merging.

@rocky rocky merged commit 551d249 into master May 3, 2021
@rocky rocky deleted the improveexpand-rebase branch May 3, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand does not accept a second argument

2 participants