Conversation
rocky
force-pushed
the
file-module
branch
3 times, most recently
from
cc02447 to
385904e
Compare
mmatera
reviewed
May 1, 2021
| builtins_by_module = {} | ||
|
|
||
| for subdir in ("drawing", "numbers", "specialfns",): | ||
| disable_file_module_names = ["files_io.files", "files_io.importexport"] if ENABLE_FILES_MODULE else [] |
Contributor
There was a problem hiding this comment.
I do not get this line: why you put things in a list of disabled, if that modules are enabled?
Member
Author
There was a problem hiding this comment.
You are absolutely correct - this is backwards! Fixing now...
(It was an artifact of not properly transforming more complicated code...)
Contributor
|
Apart from that, it seems to be OK |
Member
Author
Thanks again for checking over. Should be fixed in b05c648 and I've moved more of the Main Loop objects from expression here and started documenting this better. So please doublecheck that I haven't botched things further in doing this. Thanks. |
Also move Main Loop objects and document Main Loop better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.