Conversation
rocky
force-pushed
the
Get-relative-file
branch
2 times, most recently
from
1eae070 to
2f41b4d
Compare
* Synchronize PATH_VAR when $Path at least before mathics_open is called. * Add to_python option string_quotes: boolean. If False don't add extra surrounding quotes * Remove extra space in list in Mainloop doc
mmatera
reviewed
May 2, 2021
|
|
||
| def to_python(self, *args, **kwargs) -> str: | ||
| return '"%s"' % self.value # add quotes to distinguish from Symbols | ||
| if kwargs.get("string_quotes", True): |
Contributor
There was a problem hiding this comment.
Just in case, I shouldn't be useful to have string_quotes with True as default value, for backward compatibility?
Member
Author
There was a problem hiding this comment.
I don't understand. If you haven't set "string_quotes", it defaults to True. Almost all of the code currently is this way: no parameter is set.
If you pass this parameter, then you set it accordingly.
I had thought about a better name, and at some in the past called it something else, but I can't remember the name.
Contributor
There was a problem hiding this comment.
You are right! Discard my comment, please.
mmatera
approved these changes
May 2, 2021
Contributor
mmatera
left a comment
mmatera
left a comment
There was a problem hiding this comment.
Apart from the small comment, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PATH_VARto $Path at least beforemathics_open()is called.Falsedon't add extra surrounding quotes.Partially addresses #1329