Fix runtime bugs seen from GS3.m in per_expr()#937
Merged
Conversation
per_expr() needs to return a in interator return, not the default implied `return None` as can happen. In Python 3, // is used for truncated integer division. In Python 2 it was /. That now returns float in Python 3. Note the brokenness of self.get_wrappings To reproduce brokenness before build, in `mathics` run: ``` <<"https://raw.githubusercontent.com/rebcabin/Mathics/master/mathics/packages/GS3.m" ```
Member
Author
|
Although this doesn't fully fix GS3.m mentioned in the PR, it doesn't give a traceback most likely closer to correct. |
GarkGarcia
reviewed
Oct 3, 2020
I'm still not 100% this is correct, just probably and circumstantially correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per_expr() needs to return a in interator return, not the default implied
return Noneas can happen.In Python 3, // is used for truncated integer division. In Python 2 it
was /. That now returns float in Python 3.
Note the brokenness of self.get_wrappings
To reproduce brokenness before build, in
mathicsrun: