Conversation
Update README and bump version
Update tests Resolves #387
|
I'm not sure why two commits are listed. I had accidentally opened this to master, then closed, then switched to develop and re-opened. |
It's probably because I messed up the travis change and merged into master, and then had to do the same to develop. The merge to develop technically isn't in master; even though it is the same change, the merge is a new commit. I will make the 2.0.2 release once MathJax v2.7.3 is out, updating the package.json to call in the new version as well. |
Thanks. I have a fix for #134 in the works but that can wait until after 2.0.2 (since it would bump to 2.1.0, right?) |
|
Yes, I think that is right. |
| t.ok(data.svgNode instanceof window.HTMLElement, 'svgNode is an HTMLElement'); | ||
| t.ok(data.mmlNode instanceof window.HTMLElement, 'mmlNode is an HTMLElement'); | ||
| t.ok(data.svgNode instanceof window.SVGElement, 'svgNode is an HTMLElement'); | ||
| t.ok(data.mmlNode instanceof window.Element, 'mmlNode is an HTMLElement'); |
There was a problem hiding this comment.
Shouldn't these read svgNode is an SVGElement and mmlNode is an Element instead of HTMLElement for both?
There was a problem hiding this comment.
Yes. But it's merged now?
There was a problem hiding this comment.
Yes, I was adding this to remind myself to fix it in a new PR.
There was a problem hiding this comment.
Thanks for clarifying.
2 participants
No description provided.