Refactor/explorer depth #1052
Merged
Refactor/explorer depth #1052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpvc
approved these changes
Feb 8, 2024
Member
dpvc
left a comment
dpvc
left a comment
There was a problem hiding this comment.
This looks fine, other than question about key to use for depth.
| ['<', this.nextStyle.bind(this)], | ||
| ['x', this.summary.bind(this)], | ||
| ['-', this.expand.bind(this)], | ||
| ['d', this.depth.bind(this)], |
Member
There was a problem hiding this comment.
I'm wondering if this should be a symbol rather than a letter, like = or #, instead of a letter that ties to a word in a particular language.
Member
Author
There was a problem hiding this comment.
The problem with these symbols is that on many keyboard layouts they are only reachable via shift.
I will merge for now and then change it in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR
InPlacemovesInPlacemoves are those, that generate a different speech output without actually walking in the DOM, like summary or depth. They need to be copied into thearia-label, the node needs to be refocused to alert a screen reader and they need to be cleaned up on the next move (ie., the original speech needs to be copied back into thearia-label).This needs some changes in SRE that I still need to push.