Skip to content

Conversation

@zorkow
Copy link
Member

@zorkow zorkow commented Jun 27, 2024

Adds tests for errors in TeX packages in preparation of the l10n TexError rewrite. Note, that this is not fully complete coverage for all occurring TexErrors, but should be sufficient for the time being to actually work on the TexError refactoring.

In addition the PR adds:

  • An Emacs .el script for ease of working with jest test output in Emacs. This is partially lifted from the old script in MathJax-Tests repository.
  • Some tests to achieve complete coverage for packages: braket, unicode
  • The old ConfigMacros tests.
  • Updates tests that failed after merging PR Corrects Duplicate use of Error Messages #1106 .

@zorkow zorkow requested a review from dpvc June 27, 2024 11:58
@dpvc dpvc added this to the v4.0 milestone Jun 27, 2024
Copy link
Member

@dpvc dpvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The console.log() calls need to be removed, but other than that, it looks like a good start.

@zorkow
Copy link
Member Author

zorkow commented Jul 9, 2024

As discussed yesterday, I've added a few more tests for completeness of ConfigMacros as well as for the sideset macro in AMS. Also one correction to the jest-replace-expected-for-actual function in test-diff.el.

PTAL.

@zorkow zorkow requested a review from dpvc July 9, 2024 11:04
Copy link
Member

@dpvc dpvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@zorkow zorkow merged commit 8deaf88 into develop Jul 9, 2024
@zorkow zorkow deleted the tests/tex_error_coverage branch July 9, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants