Skip to content

Removes occurrences of aliased this#1161

Merged
zorkow merged 5 commits intodevelopfrom
refactor/aliased_this
Nov 15, 2024
Merged

Removes occurrences of aliased this#1161
zorkow merged 5 commits intodevelopfrom
refactor/aliased_this

Conversation

@zorkow
Copy link
Copy Markdown
Member

@zorkow zorkow commented Nov 12, 2024

Removes all aliasing of this in the code.
Note, that the function in Factory.ts works because arrow functions preserve lexical scope.

@zorkow zorkow marked this pull request as draft November 12, 2024 01:04
@zorkow zorkow changed the title Removes occurrences of aliased this when possible Removes occurrences of aliased this Nov 12, 2024
@zorkow zorkow requested a review from dpvc November 12, 2024 13:40
@zorkow zorkow marked this pull request as ready for review November 12, 2024 13:40
@dpvc dpvc added this to the v4.0 milestone Nov 12, 2024
Copy link
Copy Markdown
Member

@dpvc dpvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good.

Base automatically changed from refactor/remove_startup_namespace to develop November 15, 2024 00:03
@zorkow zorkow merged commit 70a6a4b into develop Nov 15, 2024
@zorkow zorkow deleted the refactor/aliased_this branch November 15, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants