Update tests to correspond with the changes for mathjax/MathJax#3300#1164
Merged
Update tests to correspond with the changes for mathjax/MathJax#3300#1164
Conversation
zorkow
approved these changes
Nov 18, 2024
Member
zorkow
left a comment
zorkow
left a comment
There was a problem hiding this comment.
Indeed, 6 newcommand tests are still failing.
Otherwise looks good.
Member
Author
|
The PR that fixes those is available now as #1165. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the tests to handle the changes from #1146 that resolved mathjax/MathJax#3300. These are mostly changes for the removal of
mstyleelements that are no longer needed, or the removal of somedisplaystyleorscriptlevelattributes that are redundant.Some
newcommandtests still fail, but they will pass with the PR that updates the\letcommand (I'm preparing it now).