Add version number to default font URLs on jsdelivr#1423
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1423 +/- ##
==========================================
Coverage 86.51% 86.51%
==========================================
Files 340 340
Lines 85993 86001 +8
Branches 4825 3186 -1639
==========================================
+ Hits 74397 74405 +8
Misses 11596 11596 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds version numbers to the URLs for fonts when they come from cdn.jsdeliver.net (the default). Without this, MathJax will load the latest font version, even if MathJax is not the latest version. This can lead to version mismatch warnings, and potentially to failures if the latest version has incompatible changes with the version being used.
This also adds support for inserting the Mathjax version number into the
fontPathconfiguration value, so that if you move to a different CDN, you can include the version number in the appropriate place for that CDN.This should improve the stability of MathJax as we make more v4 releases.