Fix inline linebreaking issues with SVG output. (mathjax/MathJax#3526)#1436
Merged
Fix inline linebreaking issues with SVG output. (mathjax/MathJax#3526)#1436
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1436 +/- ##
===========================================
- Coverage 86.51% 86.50% -0.02%
===========================================
Files 340 340
Lines 86031 86044 +13
Branches 4834 4834
===========================================
Hits 74430 74430
- Misses 11577 11590 +13
Partials 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues with SVG output for inline expressions when automatic in-line breaks are enabled.
forceInlineBreaksints/output/svg.ts.forcebreakproperty. This is fixed ints/output/common.tsby removing the property that was added to the coremoin line 628.\rightleftarrowswhen used with\undersetand\stackrelMathJax#3526 was due to the line break on the embellished operator being inserted in the wrong place. When the embellished operator had several embellished parents (i.e., the core is nested several layers deep), as in the nested\undersetand\stackrelmacros, the forced break was being made between these macros rather than before the first one. This is fixed ints/output/svg/Wrapper.tsby checking that the parent element is not embellished before line breaking is performed for embellished operators.Resolves issue mathjax/MathJax#3526.