Skip to content

TexError Localisation 1#1470

Merged
zorkow merged 19 commits into
feature/localefrom
feature/locale_plus
May 19, 2026
Merged

TexError Localisation 1#1470
zorkow merged 19 commits into
feature/localefrom
feature/locale_plus

Conversation

@zorkow
Copy link
Copy Markdown
Member

@zorkow zorkow commented May 15, 2026

PR

  • Merges the old Error message into the new framework
  • Moves the JSON files into the correct place
  • Adds components constants for loading json
  • Fixes all erros to work with the new framework.

There is some overlap/duplication between messages in [tex] and [tex]/base components.

NOTE: 02b3b4a (the actual merge) is in the wrong order due to a timing issue between my laptop and my desktop.

@zorkow zorkow requested a review from dpvc May 15, 2026 10:54
@dpvc dpvc force-pushed the feature/locale branch from 978de58 to 32eb9fc Compare May 15, 2026 16:03
@dpvc dpvc force-pushed the feature/locale_plus branch from 6efb05a to 8dc5441 Compare May 15, 2026 16:03
Copy link
Copy Markdown
Member

@dpvc dpvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, modulo the issues we discussed face-to-face, and that you have fixed in later PRs. I have made a few small suggestions, and point out one place where there seems to be an issue with added code that shouldn't be there.

Comment thread ts/input/tex/base/BaseMethods.ts Outdated
Comment thread ts/input/tex/bussproofs/BussproofsMethods.ts Outdated
Comment thread ts/input/tex/mhchem/MhchemConfiguration.ts
Comment thread ts/input/tex/unicode/UnicodeConfiguration.ts Outdated
Comment thread ts/input/tex/verb/VerbConfiguration.ts
Comment thread ts/input/tex/HandlerTypes.ts Outdated
Comment thread ts/input/tex/StackItem.ts Outdated
Comment thread ts/input/tex/StackItem.ts Outdated
Comment thread ts/input/tex/StackItem.ts Outdated
@zorkow
Copy link
Copy Markdown
Member Author

zorkow commented May 17, 2026

Thanks for rebasing and going through the PR in details.
Many of the issues you pointed out are probably down to merging of old versions of code that was later linted or incorrectly resolved merge conflicts. In particular, I have now recollection of making any major changes to UnicodeConfiguration!

@zorkow
Copy link
Copy Markdown
Member Author

zorkow commented May 19, 2026

Worked on the comments. PTAL.

@zorkow zorkow requested a review from dpvc May 19, 2026 08:58
Copy link
Copy Markdown
Member

@dpvc dpvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@zorkow zorkow merged commit fa74507 into feature/locale May 19, 2026
@zorkow zorkow deleted the feature/locale_plus branch May 19, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants