Make mfrac use TeX layout. #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… script, and scriptscript). Still need to handle linethickness (particularly linethickness=0), and beveled fractions, but good enough for now.
dpvc
force-pushed
the
mfrac-improvements
branch
from
d491743 to
7ffb8b1
Compare
zorkow
reviewed
Oct 21, 2017
| bbox.combine(nbox, pad, a + 1.5 * t + Math.max(nbox.d, .25)); | ||
| bbox.combine(dbox, pad, a - 1.5 * t - Math.max(dbox.h, .75)); | ||
| bbox.w += pad + .2; | ||
| const T = (display ? 3.5 : 1.5) * this.font.params.rule_thickness;; |
| * @override | ||
| */ | ||
| public toCHTML(parent: HTMLElement) { | ||
| this.chtml = this.standardCHTMLnode(parent); |
Member
There was a problem hiding this comment.
I am a bit confused what the difference between chtml and CHTML is.
Member
Author
There was a problem hiding this comment.
CHTML is my shorthand for CommonHTML. toCHTML() is the function that creates the CommonHTML version of the internal MathML nodes (as a tree of HTML elements). this.chtml is a cached pointer to the subtree for this (wrapped) internal MathML node.
Member
Author
|
I've made the requested changes. |
Member
|
Lgtm |
zorkow
approved these changes
Nov 17, 2017
Add support for munder/mover/munderover
Add support for mub/msup/msubsup
sudhansubhushanmishra
added a commit
to sudhansubhushanmishra/MathJax-src
that referenced
this pull request
Jun 14, 2021
Line mathjax#48 had a typo, of {OptionLis} instead of {OptionList}
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make fractions conform to TeX spacing, for all styles (display, text, script, and scriptscript). Also, properly handle
\largeand other sizing macros. Still need to handle linethickness (particularly linethickness=0), and beveled fractions, but good enough for now.This also includes a change to the CHTMLWrapper's
handleScale()which allows you to set the scale on any node (not just the top-level one). This was originally going to be needed for the struts that enforce some spacing rules, but it ended up not being needed. But I left the change in since it might be useful to break out the setting of the scale as a separate function.Some of the constants used in the bounding box computation should be taken from the font parameters, but for now those values are hard-coded into the CSS, so I've hard coded them into the BBox computation as well. Eventually, that will need to be fixed.