V2 fixes #53
Merged
V2 fixes #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that it becomes just withDelims
…t really shouod have been explicit mrows (e.g., in \frac{ab}c).
zorkow
reviewed
Oct 21, 2017
| 'autoOP' | ||
| ]; | ||
| var RENAME = { | ||
| texWithDelims: 'withDelims' |
Member
There was a problem hiding this comment.
Is there a reason for the name change?
Member
Author
There was a problem hiding this comment.
Because it can be used by other than TeX input.
| 'isError', | ||
| 'multiline', | ||
| 'variantForm', | ||
| 'autoOP' |
Member
Author
There was a problem hiding this comment.
Ok, I'll add it. There are undoubtedly some other ones I've missed as well.
Member
Author
|
Changes made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[I accidentally closed this PR, and don't seem to be able to reopen it, so I'm submitting it again. I don't think Volker had any comment on it yet. Sorry about the problem. Also messed up the table PR where there were comments, but I will fix the problems raised and resubmit that PR as well.]
This fixes a number of small issues with attribute inheritance in MmlNodes, and with the bounding boxes in CHTML.
Although the
mathsizeattribute is only allowed on token elements, we want it to affect things like fractions, roots, tables, etc., so that when\largeand the other sizing macros are used, everything scales appropriately. Similarly,<math mathsize="200%">...</math>should scale everything up, not just the token elements.When inheriting values check for default attribute values only in the actual default list, not the chained global defaults (now that the global defaults are in the chain).
The
<math>element should set thedisplaystyleas an inherited value, since its default value is computed from several other values, when not explicitly given.Fix the handling of
displaystylein<mstyle>In CHTML, the bounding boxes are now computed in place by
computeBBox(), rather than creating new BBox structures each time. But that means that whengetBBox()is called withsave = false, then the box is saved anyway. SocomputeBBox()was changed to accept the BBox to be used, andgetBBox()passes it either the original box (when the value is to be saved), or a new zeroed box (if the box isn't being saved). The CHTMLWrappercomputeBBox()implementations are modified to include the BBox parameter. The return value is no longer needed, since the BBox is passed to it.Finally,
super.computeBBox()is replaced bythis.childNode[0].getBBox(), since that way you get the cached bounding box of the inferred row (the only child), rather than creating a new BBox and appending one BBox to it (extra work for nothing).