Implement remaining mfrac attributes #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d fractions, and will be needed for mfenced as well.
zorkow
approved these changes
May 2, 2018
| const fparam = this.font.params; | ||
| if (t !== .06) { | ||
| const a = fparam.axis_height; | ||
| const tEm = this.em(t), T = (display ? 3.5 : 1.5) * t; |
| const a = fparam.axis_height; | ||
| const T = (display ? 3.5 : 1.5) * t; | ||
| bbox.combine(nbox, 0, a + T + Math.max(nbox.d * nbox.rscale, (display ? fparam.num1 : fparam.num2) - a - T)); | ||
| bbox.combine(dbox, 0, a - T - Math.max(dbox.h * dbox.rscale, (display ? fparam.denom1 : fparam.denom2) + a - T)); |
Member
There was a problem hiding this comment.
Some computations are the same as in makeFraction (a and second args of Math.max).
Could they be combined into an aux method, thereby shortening some of these lines?
Member
|
I've just realised that you are using |
Member
|
I found the relevant discussion for |
…nsistnecy with other files).
Member
Author
|
I've fixed the issues, including |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes the CommonHTML output for
mfrac. It implements thebevelledattribute, implementslinethickness, and in particular support forlinethickness="0"which requires a different layout (in the TeXBook appendix G), and adds support fornumalignanddenomalignattributes.As a side effect, the
createMo()method has been moved frommsqrt.tsto the baseWrapper.tsfile, since it is needed for the bevelled fractions, and will be needed formfencedin the future.