Table support #54
Merged
Table support #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[I deleted the branch the original PR was being merged to, and the old PR it was closed automatically. So I'm making a new one. It already addresses Volker's comments from the old one. Again, sorry for the error.]
This PR adds support for
mtable/mtr/mtd. Not allmtableattributes are supported (so far, onlycolumnspacing,rowspacing,columnalign,rowalign,columnlines,rowlines,frame, andframespacing). This is enough for most of the TeX requirements. Labeled rows are handled, but the label is dropped for now. Still to be done are things like setting column widths, forcing equal columns and rows, label support, and setting the table width (in particular, percentage width tables). Note that partial frames (possible within LaTeX's array environment) rely onmenclose, which is not yet implemented.But for now, this is pretty good.
This also includes fixes for some typos in comments, and a fix for incorrect inheritance of
mtrandmtdattributes frommtableelements.