A11y virtual attached keyexplorers #683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpvc
reviewed
Apr 14, 2021
| * @param {ExplorerMathDocument} document The current document. | ||
| */ | ||
| public attachExplorers(document: ExplorerMathDocument) { | ||
| this.attached = []; |
Member
There was a problem hiding this comment.
It looks like this.attached is no longer created or populated, but it is still used elsewhere in the code (in rerender() and updateDocument()). Is that still correct?
Member
Author
There was a problem hiding this comment.
Good catch.
I've now also made the more restarting more robust on collapsed elements. This only works with the latest fixes I made to SRE today.
There's still a minor kink to work out: When a collapse is triggered with the mouse while the key explorers are deeper in the tree they effectively refocus on a node that is no longer there. But that is for 3.2 to work out.
the refocus does not y
Member
Author
There was a problem hiding this comment.
Solved that problem now. I will make a small PR once this PR is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes care of item 1 in #561 (comment)
Original problem was that key explorers where added to a node when they were switched on and removed when switched off.
Since only the last explorer was supposed to stop propagation of the key events, if the order was messed up, propagation might be stopped too early. (E.g., switch on speech, braille, keyboard magnificatio. Then switch off braille and speech, and switch on speech: magnification works, speech does not).
Now key explorers are attached only once and retain an
attachedflag. This ensure that the order of the explorers remains the same.