Conversation
Contributor
|
Thanks, @dpvc.
The change in spacing seems worth it.
Those phantoms do seem like overkill. I'll let you know if we ever run into very long sideset scripts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue raised by Peter with
\sideset{}{^*}{\sum}_{a\mid A_y}where the final underscore should place its argument under the sum rather than in subscript position. This is done by placing everything into a TeXAtom of class OP so that the limits are placed above and below in displaystyle.The positioning is not quite the same as in LaTeX, however. You could get the proper placement using
but I am hesitant to add such phantoms automatically as they would have to be removed in textstyle, and would also require special processing of subscript and superscripts that follow the
\sideset. That could be done, but would require additional StackItems to handle it.