feat(onboarding): add mission and lifecycle support prompts - #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
npm run test:lifecycle(7 passing policy tests)npm run typechecknpx expo export --platform android --output-dir /tmp/opennotes-android-export-finalgit diff --checkand trailing-whitespace scan passedReview gates
app/index.tsxis 498 lines after extracting lifecycle support logic. The 903-line note editor predates this change; this PR makes only a surgical successful-save instrumentation change there, and splitting that editor in this feature would increase regression risk.https://discord.gg/VWKmgMgYu.npm audit --omit=dev --audit-level=highreports 30 pre-existing transitive Expo/toolchain advisories, including 2 critical findings. Available forced remediation upgrades Expo across a breaking SDK boundary, so this PR must remain open and must not be self-merged until that repository-wide dependency gate is resolved.