Skip to content

fix(editor): improve text box editing with the keyboard #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dronquavious merged 4 commits into from
Aug 15, 2026
Merged

fix(editor): improve text box editing with the keyboard #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5839f4c
fix(editor): reveal new text boxes above the keyboard
Dronquavious Aug 9, 2026
e11bd51
fix(editor): allow scrolling in multiline text boxes
Dronquavious Aug 9, 2026
e98cb52
fix(editor): give new text boxes a usable default height
Dronquavious Aug 9, 2026
366e821
retrigger checks
Dronquavious Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions app/note/[id].tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import {
Alert,
BackHandler,
Keyboard,
KeyboardAvoidingView,
Platform,
StyleSheet,
View,
useWindowDimensions,
Expand Down Expand Up @@ -529,8 +531,19 @@ export default function NoteScreen() {
...state,
textBoxes: [...state.textBoxes, box],
}));
const needsTrailingBlankPage = pageIndex >= enginePages.length - 1;
const ensureTrailingBlankPage = needsTrailingBlankPage
? canvasRef.current?.addPage({ force: true, scroll: false })
: Promise.resolve();
void ensureTrailingBlankPage?.finally(() => {
// Wait for the keyboard and its layout resize before positioning the
// active line. This preserves the user's current page position.
setTimeout(() => {
canvasRef.current?.revealPagePosition(pageIndex, box.y, true);
}, 250);
});
},
[mutateOverlay],
[enginePages.length, mutateOverlay],
);

const handleUpdateTextBox = useCallback(
Expand Down Expand Up @@ -752,7 +765,10 @@ export default function NoteScreen() {
onExport={() => void handleExport()}
/>

<View style={styles.canvasArea}>
<KeyboardAvoidingView
behavior={Platform.OS === 'ios' ? 'padding' : undefined}
style={styles.canvasArea}
>
<InfiniteInkCanvas
ref={canvasRef}
style={styles.flex}
Expand Down Expand Up @@ -788,7 +804,7 @@ export default function NoteScreen() {
onRemoveInsertedElement={handleRemoveInsertedElement}
onCreateTextBoxId={textBoxId}
/>
</View>
</KeyboardAvoidingView>

<FloatingToolbar
activeTool={toolState.toolType as ToolDescriptor['type']}
Expand Down
4 changes: 3 additions & 1 deletion src/components/editor/OverlayLayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,9 @@ export function OverlayLayer({
x: Math.max(0, coord.x - 6),
y: Math.max(0, coord.y - 12),
width: 240,
height: 36,
// Give a new note enough room for several lines before its internal
// editor needs to scroll.
height: 120,
content: '',
color: activeColor,
fontSize: 18,
Expand Down
4 changes: 3 additions & 1 deletion src/components/editor/TextBoxOverlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,9 @@ export function TextBoxOverlay({
value={localContent}
onChangeText={handleContentChange}
multiline
scrollEnabled={false}
// Keep the insertion point reachable when the text is longer
// than the box, particularly while the software keyboard is up.
scrollEnabled
style={[
styles.input,
{
Expand Down
Loading