Skip to content

Fix PDF notebook stability and selection gestures#34

Merged
markm39 merged 1 commit into
mainfrom
fix/large-pdf-background-windowing
May 20, 2026
Merged

Fix PDF notebook stability and selection gestures#34
markm39 merged 1 commit into
mainfrom
fix/large-pdf-background-windowing

Conversation

@markm39
Copy link
Copy Markdown
Contributor

@markm39 markm39 commented May 20, 2026

Summary

  • Window PDF page backgrounds around the visible page and cache CGPDF documents to reduce large-notebook memory pressure.
  • Fix PDF export page selection/render sizing by using requested page indices and consistent CGPDF rendering.
  • Route native selection events correctly and block single-finger viewport pan over selected native objects so finger dragging reaches the selected figure/shape.
  • Avoid native capture during slot teardown to prevent back/navigation crashes, and preserve imported PDF page counts without adding a disposable blank.

Verification

  • npm run typecheck
  • npm test
  • npm run test:native:smoke
  • npm run build
  • npm run pack:dry-run
  • npm run test:example:typecheck
  • npm run test:example:export:ios
  • npm run test:example:export:android
  • simplify review: no findings
  • security review: no findings

Notes

  • Replayed over origin/main after Add crisp zoom rendering #33 (feat(ink): add crisp zoom rendering).
  • Did not run a device/Xcode build in this session.

@markm39 markm39 merged commit e47dfc3 into main May 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant