Skip to content
This repository was archived by the owner on Mar 27, 2025. It is now read-only.

Conversation

@nbhoski
Copy link
Member

@nbhoski nbhoski commented Jun 18, 2020

  • Added support to run MATLAB command through script file to address the issues of "" and other special characters.
  • Writing the command in command_UUID.m script file and passing that as a parameter to run_matalb_command(bat|sh) script .
  • cleaning the entire temp folder after job completion.
  • Few tests which were based on console output of the command has been disabled as now commands cannot be seen on the console window as it will be wrapped in temp script file . I shall add them back to integ-tests once integ-test folders merged.

Copy link
Member

@mcafaro mcafaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about displaying the contents of the script in the console log?

Also consider adding an integ test that runs something like:

a = " !""#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\]^_`abcdefghijklmnopqrstuvwxyz{|}~"; b = char([32:126]); assert(strcmp(a, b), a+b);

through the Run MATLAB Command build step. And make sure that integ test gets run on Linux and Windows.

@nbhoski nbhoski requested a review from mcafaro June 19, 2020 11:24
Copy link
Member

@mcafaro mcafaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nbhoski nbhoski requested a review from mw-akumar June 23, 2020 07:13
@nbhoski nbhoski requested a review from mw-akumar June 23, 2020 11:19
@nbhoski nbhoski requested a review from mw-hrastega June 26, 2020 07:20
Copy link
Member

@mw-hrastega mw-hrastega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine to me.

@nbhoski nbhoski merged commit 2c46140 into master Jun 30, 2020
@nbhoski nbhoski deleted the matlab_cmd_as_script branch September 3, 2020 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants