This repository was archived by the owner on Mar 27, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
Matlab cmd as script #112
Merged
Merged
Matlab cmd as script #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nbhoski
commented
Jun 18, 2020
- Added support to run MATLAB command through script file to address the issues of "" and other special characters.
- Writing the command in command_UUID.m script file and passing that as a parameter to run_matalb_command(bat|sh) script .
- cleaning the entire temp folder after job completion.
- Few tests which were based on console output of the command has been disabled as now commands cannot be seen on the console window as it will be wrapped in temp script file . I shall add them back to integ-tests once integ-test folders merged.
mcafaro
reviewed
Jun 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about displaying the contents of the script in the console log?
Also consider adding an integ test that runs something like:
a = " !""#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\]^_`abcdefghijklmnopqrstuvwxyz{|}~"; b = char([32:126]); assert(strcmp(a, b), a+b);
through the Run MATLAB Command build step. And make sure that integ test gets run on Linux and Windows.
mcafaro
approved these changes
Jun 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
mw-akumar
suggested changes
Jun 22, 2020
mw-akumar
reviewed
Jun 23, 2020
mw-akumar
approved these changes
Jun 23, 2020
nbhoski
commented
Jun 26, 2020
src/main/resources/com/mathworks/ci/RunMatlabCommandBuilder/help-matlabCommand.html
Outdated
Show resolved
Hide resolved
mw-hrastega
approved these changes
Jun 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look fine to me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.