This repository was archived by the owner on Mar 27, 2025. It is now read-only.
Added unit tests to improve code coverage #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbhoski
requested review from
SangaviJayagopi,
acampbel,
jwilkick-mw,
mcafaro and
mw-akumar
jwilkick-mw
reviewed
Apr 30, 2019
jwilkick-mw
reviewed
May 6, 2019
jwilkick-mw
approved these changes
May 8, 2019
| .replace("R2017a", version); | ||
| } | ||
| return matlabRoot; | ||
| String defaultVersionInfo = "versioninfo/R2017a/" + VERSION_INFO_XML_FILE; |
There was a problem hiding this comment.
Nice use of a constant here! Perhaps could do the same for "versioninfo/" in case that path changes?
Also, this might not be called often enough to really matter, but maybe a StringBuilder in here? If you only call this once or twice, it probably doesn't matter that much and it is pretty readable as is, so I don't think it is a blocker.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.