This repository was archived by the owner on Mar 27, 2025. It is now read-only.
Fix for g2136203 and cobertura model coverage #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbhoski
approved these changes
Dec 9, 2019
hkhan17
changed the title
nbhoski
approved these changes
Dec 11, 2019
anjanak-dev
approved these changes
Dec 11, 2019
SangaviJayagopi
approved these changes
Dec 11, 2019
nbhoski
suggested changes
Dec 12, 2019
Member
nbhoski
left a comment
nbhoski
left a comment
There was a problem hiding this comment.
Sorry for overlooking these , Line 620 . static members does not require to have Class instance created
MatlabBuilderConstants constants = new MatlabBuilderConstants(); you can directly access them using class name directly.
nbhoski
approved these changes
Dec 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes here:
There was an incorrect syntax in runMatlabTests call for versions below R2018b - g2136203
Cobertura model coverage is not supported in R2018a. It is only supported from R2018b onwards.