CachingPageTracer Optimization#172
Merged
tonyastolfi merged 5 commits intomathworks:mainfrom Nov 6, 2024
Merged
Conversation
vidyasilai
requested review from
bhaskarbora2,
gabrielbornstein and
tonyastolfi
tonyastolfi
reviewed
Oct 28, 2024
Collaborator
tonyastolfi
left a comment
tonyastolfi
left a comment
There was a problem hiding this comment.
Here is my initial review.
I'm going to think about finalized_deleted_pages_ based on your comments. I'm not sure it is needed either, but want to give myself some time to ponder.
Thanks for this PR!
tonyastolfi
reviewed
Nov 1, 2024
tonyastolfi
reviewed
Nov 1, 2024
tonyastolfi
reviewed
Nov 1, 2024
tonyastolfi
reviewed
Nov 1, 2024
tonyastolfi
reviewed
Nov 1, 2024
tonyastolfi
reviewed
Nov 1, 2024
tonyastolfi
reviewed
Nov 1, 2024
Collaborator
tonyastolfi
left a comment
tonyastolfi
left a comment
There was a problem hiding this comment.
Thanks for the offline explanation of the purpose of finalized_deleted_pages_. I like the idea, just think the polarity of the set should be reversed to optimize the common case, as noted in a new comment at the declaration of this data member.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a solution to the issue described in #170. It builds upon the existing PageTracer infrastructure to cache outgoing reference information for pages.