Add an option to parse only hunk positions#68
Merged
matiasb merged 1 commit intomatiasb:masterfrom Apr 22, 2020
Merged
Conversation
Owner
|
Looks good! Just pushed an updated PR (#70) solving the conflict and with some refactoring, besides renaming the param as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my use case I'm using this great library to figure out how code has moved around. For this use case the only thing that matters is the hunk positions and sizes. Unfortunately full diff parsing uses large amount of memory and is slow and there's no way to disable it in this library.
This PR adds a new option
only_hunk_positionsthat enables a fast code path that only parses the hunk headers, only does minimal parsing of the line contents and does not store them. Enabling this option results in ~20 times less memory use and 6 times faster diff parsing on Python 3.6 (2.5 times on Python 2.7).