Added option to only parse diff metadata#70
Merged
Conversation
matiasb
force-pushed
the
p12tic-only-hunk-positions
branch
from
0a4510c to
3273435
Compare
Contributor
|
This approach could affect performance, my previous approach took care not to do extra calculations which resulted in some code duplication. I'll test the performance impact and get back with real numbers. |
Owner
Author
|
Ok, let me know! Note that I'm not changing substantially the proposed updates, but just counting the added/removed lines to keep that metadata values still available. |
Owner
Author
|
FYI, merging the changes, we can keep discussing alternatives. Will prepare a release in the next coming days too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some refactoring on top of #68.
Thanks p12tic!