Update the processed report expectation for the report ratio columns - #138
Draft
tzi wants to merge 1 commit into
Draft
Update the processed report expectation for the report ratio columns#138tzi wants to merge 1 commit into
tzi wants to merge 1 commit into
Conversation
API.getProcessedReport gained a percentage-of-the-report-total column for every metric that supports a report total ratio, see matomo-org/matomo#24990.
tzi
added a commit
to matomo-org/matomo
that referenced
this pull request
Aug 4, 2026
…ation The pinned commit and prepare6x had identical trees, so this only brings in the regenerated processed report expectation. Re-pin to the merged commit once matomo-org/plugin-CustomVariables#138 lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the
TwoVisitsWithCustomVariablesprocessed report expectation for the percentage-of-the-report-total columns that matomo-org/matomo#24990 adds toAPI.getProcessedReport.Impact
None visible to users: this is a test expectation only.
Step by step tests
Automated
The expectation was regenerated against this branch's tree, with matomo-org/matomo#24990 applied to core:
plugins/CustomVariables.ddev exec "cd /var/www/html/tests/PHPUnit && vendor/bin/phpunit ../../plugins/CustomVariables/tests/System/TwoVisitsWithCustomVariablesTest.php".👁️ 5 tests pass.
The added lines are only the new
nb_visits_report_ratio/nb_actions_report_ratioentries incolumnsand on each row: stripping them reproduces the previous expectation byte for byte.Checklist