Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect not working for updated contribute page #27911

Closed
tacaswell opened this issue Mar 12, 2024 · 1 comment · Fixed by #27915
Closed

redirect not working for updated contribute page #27911

tacaswell opened this issue Mar 12, 2024 · 1 comment · Fixed by #27915
Milestone

Comments

@tacaswell
Copy link
Member

tacaswell commented Mar 12, 2024

There should be a re-direct there:

.. redirect-from:: /devel/contributing
.. _contributing:

We should merge this to avoid the redirect in our links, but we should also sort out why the redirect is not working.

Originally posted by @tacaswell in #27910 (comment)

@AnsonTran
Copy link
Contributor

The issue seems to be with this line of code here: https://github.com/matplotlib/matplotlib/blob/5a4bb71f640a3c4dd8aac1af8952fe336da428b8/doc/sphinxext/redirect_from.py#L110C1-L110C5.

app.env.get_domain('redirect_from').redirects is an empty dictionary, so none of the redirect HTML pages get created. My guess is that it is being cleared somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants