Fix saving PNGs to file objects in some places#16709
Merged
timhoffm merged 2 commits intomatplotlib:v3.2.xfrom Mar 8, 2020
Merged
Fix saving PNGs to file objects in some places#16709timhoffm merged 2 commits intomatplotlib:v3.2.xfrom
timhoffm merged 2 commits intomatplotlib:v3.2.xfrom
Conversation
anntzer
approved these changes
Mar 8, 2020
timhoffm
approved these changes
Mar 8, 2020
This was referenced Mar 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The IPython automated rebuild started failing when Matplotlib 3.2.0 was introduced, with stuff like:
MathText.to_pngis documented as accepting a file-like object though, and this was dropped accidentally as the_pngmodule was refactored, so this PR fixes that. I also found that_ImageBase.write_pngwas changed in a similar way in the same commit, so I also modified it. But I couldn't find any usage of it and its parameters are undocumented, so I'm not sure whether that was necessary.This PR targets
v3.2.xdirectly, becausemasterwas subsequently switched to direct Pillow calls that accept file-like objects themselves.PR Checklist