Make image_comparison work even without the autoclose fixture.#21256
Merged
QuLogic merged 1 commit intomatplotlib:masterfrom Oct 14, 2021
Merged
Make image_comparison work even without the autoclose fixture.#21256QuLogic merged 1 commit intomatplotlib:masterfrom
QuLogic merged 1 commit intomatplotlib:masterfrom
Conversation
jklymak
approved these changes
Oct 12, 2021
timhoffm
approved these changes
Oct 13, 2021
Member
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
Minor style comment.
Which release do we want to target with this?
... by capturing only the images created during the execution of the test, and closing them after the comparison.
Contributor
Author
|
Style fixed. I don't have a preference re: targetted version. |
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Make image_comparison work even without the autoclose fixture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... by capturing only the images created during the execution of the
test, and closing them after the comparison.
Closes #18168.
I guess a test would be nice, but I didn't really want to go through the machinery of figuring out how to disable the autoused closing fixture...
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).