Skip to content

Stash exceptions when FT2Font closes the underlying stream.#21407

Merged
jklymak merged 1 commit intomatplotlib:mainfrom
anntzer:cfe
Oct 26, 2021
Merged

Stash exceptions when FT2Font closes the underlying stream.#21407
jklymak merged 1 commit intomatplotlib:mainfrom
anntzer:cfe

Conversation

@anntzer
Copy link
Copy Markdown
Contributor

@anntzer anntzer commented Oct 20, 2021

Previously, PyErr_Occurred could also catch exceptions that have been
set earlier, and have nothing to do with file closing.

Closes #21364. It's not a perfect solution (see discussion from #21364 (comment)), but should be enough in practice...

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Previously, PyErr_Occurred could also catch exceptions that have been
set earlier, and have nothing to do with file closing.
@anntzer anntzer added this to the v3.6.0 milestone Oct 20, 2021
@jklymak jklymak merged commit 1f7b6d1 into matplotlib:main Oct 26, 2021
@anntzer anntzer deleted the cfe branch October 26, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: double free when FT2Font constructor is interrupted by KeyboardInterrupt

3 participants