Merged
Conversation
timhoffm
force-pushed
the
triplot
branch
3 times, most recently
from
382eca7 to
a8b9429
Compare
anntzer
reviewed
Jan 29, 2022
|
|
||
| collection.set_alpha(alpha) | ||
| collection.set_array(C) | ||
| collection.set_array(colors) |
Contributor
Member
Author
There was a problem hiding this comment.
But there is collection._scale_norm(norm, vmin, vmax) after setting the norm here. AFAICS this handles the issue in #21146/#21525. One can probably remove that when delaying kwargs setting. But since this PR is already complicated enough and there is no immediate problem, I'd not go into this within this PR.
QuLogic
reviewed
Mar 25, 2022
timhoffm
force-pushed
the
triplot
branch
2 times, most recently
from
be7e1e2 to
ef81739
Compare
This issues more and more precise warnings on usage errors but does not change behavior. Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
QuLogic
approved these changes
Mar 29, 2022
Member
|
Oops, thought there was a second review; hope you're okay with this @anntzer? |
Contributor
|
No worries, opened #22726 to track the rest. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Commits:
Triangulation.get_from_args_and_kwargsto make parameter parsing testable; and add tests.trianglesormaskalongside aTriangulationtotripcolor()tripcolor()This issues additional warnings and more precise error messages but does not change behavior.
The only "semantic" change is that I have discouraged passing triangles positionally:
tripcolor(x, y, triangles, C)is a bit odd and IMHO has too many positional arguments.
Closes #22303. Follows up on #10148.