Normalize tk load failures to ImportErrors.#23089
Merged
oscargus merged 1 commit intomatplotlib:mainfrom May 22, 2022
Merged
Conversation
Wrapping the internally raised exception should make it easier to debug any failures. Test e.g. by replacing `__file__` by `_file_` in the same source file and recompiling to trigger an AttributeError-that-gets-wrapped-by-ImportError.
timhoffm
approved these changes
May 21, 2022
oscargus
approved these changes
May 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapping the internally raised exception should make it easier
to debug any failures. Test e.g. by replacing
__file__by_file_in the same source file and recompiling to trigger anAttributeError-that-gets-wrapped-by-ImportError.
See #23074 (comment).
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).