Combine chunk size tests into one#23413
Merged
oscargus merged 1 commit intomatplotlib:mainfrom Jul 12, 2022
Merged
Conversation
Each one allocates over 2G, and are right next to each other, so when running in parallel, they can combine to OOM very easily. It would be nice to drop the large memory usage entirely, but at least we can remove 5 extra copies of it.
anntzer
approved these changes
Jul 12, 2022
oscargus
approved these changes
Jul 12, 2022
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Jul 12, 2022
oscargus
pushed a commit
to oscargus/matplotlib
that referenced
this pull request
Jul 20, 2022
Each one allocates over 2G, and are right next to each other, so when running in parallel, they can combine to OOM very easily. It would be nice to drop the large memory usage entirely, but at least we can remove 5 extra copies of it.
oscargus
pushed a commit
to oscargus/matplotlib
that referenced
this pull request
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Each one allocates over 2G, and are right next to each other, so when running in parallel, they can combine to OOM very easily. It would be nice to drop the large memory usage entirely, but at least we can remove 5 extra copies of it.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).