Skip to content

Remove old handling for factor=None in axisartist.#23467

Merged
timhoffm merged 1 commit intomatplotlib:mainfrom
anntzer:fn
Jul 22, 2022
Merged

Remove old handling for factor=None in axisartist.#23467
timhoffm merged 1 commit intomatplotlib:mainfrom
anntzer:fn

Conversation

@anntzer
Copy link
Copy Markdown
Contributor

@anntzer anntzer commented Jul 22, 2022

factor=None (meaning =1) was deprecated in e900be3 (3.2) and support for
factor=None was removed everywhere else in 3.4; the changes here had
just been missed.

Also normalize lon_levs, lat_levs to arrays early, rather than having to
do this multiple times.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

factor=None (meaning =1) was deprecated in e900be3 (3.2) and support for
factor=None was removed everywhere else in 3.4; the changes here had
just been missed.

Also normalize lon_levs, lat_levs to arrays early, rather than having to
do this multiple times.
@timhoffm timhoffm modified the milestones: v3.5.3, v3.6.0 Jul 22, 2022
@timhoffm timhoffm merged commit 1e69493 into matplotlib:main Jul 22, 2022
@anntzer anntzer deleted the fn branch July 22, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants