Move the common implementation of Axes.set_x/y/zscale to Axis.#23500
Move the common implementation of Axes.set_x/y/zscale to Axis.#23500tacaswell merged 1 commit intomatplotlib:mainfrom
Conversation
... together with an _axis_method_wrapper. It may be worth trying to figure out later whether Axis._set_scale and Axis._set_axes_scale need to have subtly different behaviors...
|
The 3D-versions were not tested earlier. Would be nice to have a test that passes both before and after this PR. |
|
3D axes don't actually meaningfully support any scales other than linear, so I don't think we can really write meaningful tests there. Note that if anything this PR already improves the test coverage by getting rid of untested code (Axes3D.set_{x,y,z}scale). |
oscargus
left a comment
There was a problem hiding this comment.
It improves the coverage for sure, I'm more worried about not changing behaviour. But after a more careful reading of the code, I can probably agree with you that it does the same thing as before.
|
The docs failure is understood as the sphinx-gallery reset issue, should not block. The difference is that the autoscaling is now conditional, but I suspect that is OK. |
... together with an _axis_method_wrapper.
It may be worth trying to figure out later whether Axis._set_scale and
Axis._set_axes_scale need to have subtly different behaviors...
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).