Skip to content

Refactor Widget tests#23510

Merged
timhoffm merged 6 commits intomatplotlib:mainfrom
QuLogic:widget-test-cleanup
Aug 9, 2022
Merged

Refactor Widget tests#23510
timhoffm merged 6 commits intomatplotlib:mainfrom
QuLogic:widget-test-cleanup

Conversation

@QuLogic
Copy link
Copy Markdown
Member

@QuLogic QuLogic commented Jul 29, 2022

PR Summary

Use Mocks instead of extra attributes, parametrize tests that are calling a helper function multiple times, and use unpacking for creating event sequences.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@tacaswell tacaswell added this to the v3.6.0 milestone Aug 2, 2022
@timhoffm timhoffm merged commit 149a039 into matplotlib:main Aug 9, 2022
@QuLogic QuLogic deleted the widget-test-cleanup branch August 9, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants