warning when scatter plot color settings discarded#23516
warning when scatter plot color settings discarded#23516timhoffm merged 5 commits intomatplotlib:mainfrom swaltek:issue23487
Conversation
swaltek
changed the title
swaltek
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Not passing all tests I'll reopen if I figure out whats going on. |
|
@swaltek It is also ok to leave it open and make it a draft. |
|
It looks like the warning found some cases in the test suite where we were passing (and ignoring) arguments! The right fix is likely to drop the |
The test failing in Appreciate the comments on the PR! |
|
Do you feel comfortable squashing this to one commit? |
tacaswell
dismissed
their stale review
Agree that Tim's suggestion should be taken
|
I took back my review to take this out of the "approved review list", but for our internal counting please consider it as approved by me so only one more review is needed. |
| @@ -0,0 +1,3 @@ | |||
| Warning when scatter plot color settings discarded | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| When making an animation of a scatter plot, if you don't set *c* (the color value parameter) when initializing the artist, the color settings are ignored. `.Axes.scatter` now raises a warning if color-related settings's are changed without setting *c* | |||
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
|
Doc build failure is unrelated. |
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
|
Thanks @swaltek and congratulations on your first contribution to Matplotlib! 🎉 We hope to see you again! |
* Warning when scatter plot color settings discarded * Update lib/matplotlib/axes/_axes.py Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com> * Wrapped 23516-MS.rst lines at 80 characters * Fixed tests to look for proper warning message * Update doc/api/next_api_changes/behavior/23516-MS.rst Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com> Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com> Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
5 participants
PR Summary
first pr, happy to add/make any necessary changes
closes #23487
The changed test in
test_colorbar.pywas related removing a colorbar from a scatter plot. I don't think thecmapthere was necessary to test this. And running the tests on my own revealed thecmapwasn't changing the color of the scatter plot anywaysPR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).