Merged
Conversation
oscargus
force-pushed
the
axis3ddrawcleanup
branch
2 times, most recently
from
d5fd401 to
94cd9f8
Compare
Member
Author
|
The test failure is caused by gristlabs/asttokens#85 Not sure what the solution is:
As we do not have any (direct) dependency on |
|
asttokens 2.0.7 is released |
Member
Author
Great, thanks! |
anntzer
reviewed
Aug 8, 2022
oscargus
force-pushed
the
axis3ddrawcleanup
branch
3 times, most recently
from
011b244 to
8ac3470
Compare
QuLogic
approved these changes
Aug 9, 2022
oscargus
force-pushed
the
axis3ddrawcleanup
branch
from
8ac3470 to
38567d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Remove a bunch of redundant lookups and computations.
Restructured code a bit.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).