[MNT] Move SubplotParams from figure to gridspec #26634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
force-pushed
the
move-subplotparams
branch
from
dd4d70a
to
5223e0e
Compare
|
It probably needs a short note that says it's been moved. |
timhoffm
force-pushed
the
move-subplotparams
branch
from
5223e0e
to
025b079
Compare
QuLogic
reviewed
Aug 31, 2023
Logically, this belongs more to the gridspec layout than to the figure. There is no API breakage involved, because `matplotlib.figure` reimports `SubplotParams`. Do we nevertheless want an API change note?
timhoffm
force-pushed
the
move-subplotparams
branch
from
025b079
to
219323a
Compare
QuLogic
approved these changes
Sep 2, 2023
jklymak
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logically, this belongs more to the gridspec layout than to the figure.
There is no API breakage involved, because
matplotlib.figurereimportsSubplotParams. Do we nevertheless want an API change note?