Remove deprecated draw_gouraud_triangle#26797
Merged
QuLogic merged 2 commits intomatplotlib:mainfrom Sep 19, 2023
Merged
Conversation
oscargus
force-pushed
the
removedrawgouraudtriangle
branch
from
c96e51f to
c36c5a9
Compare
oscargus
force-pushed
the
removedrawgouraudtriangle
branch
from
04c00f9 to
819e173
Compare
ksunden
approved these changes
Sep 18, 2023
QuLogic
approved these changes
Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second commit is a minor refactoring. Maybe one should consider inlining
_draw_gouraud_trianglecompletely now?PR summary
PR checklist