Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated methods and attributed in Axes3D #26798

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Remove deprecated methods and attributed in Axes3D #26798

merged 1 commit into from
Sep 18, 2023

Conversation

oscargus
Copy link
Contributor

PR summary

PR checklist

@oscargus oscargus added this to the v3.9.0 milestone Sep 17, 2023
@scottshambaugh
Copy link
Contributor

For my own knowledge, where does the deprecation policy live? I can't find it in the devdocs.

@oscargus
Copy link
Contributor Author

Not sure... Short version:

Everything user facing. Two minor versions.

scottshambaugh
scottshambaugh requested changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@scottshambaugh scottshambaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 946-949 should get cleaned up as well

@oscargus
Copy link
Contributor Author

Fixed!

@timhoffm
Copy link
Member

For my own knowledge, where does the deprecation policy live? I can't find it in the devdocs.

https://matplotlib.org/stable/devel/contribute.html#api-changes

@timhoffm timhoffm merged commit 9c1aed1 into matplotlib:main Sep 18, 2023
40 checks passed
@oscargus oscargus deleted the axes3dremovals branch September 18, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@scottshambaugh scottshambaugh scottshambaugh approved these changes

Assignees
No one assigned
Labels
API: changes Maintenance topic: mplot3d
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oscargus @scottshambaugh @timhoffm