Add example for plotting a bihistogram#27182
Merged
scottshambaugh merged 6 commits intomatplotlib:mainfrom Oct 24, 2023
i-jey:bihistogram_example
Merged
Add example for plotting a bihistogram#27182scottshambaugh merged 6 commits intomatplotlib:mainfrom i-jey:bihistogram_example
scottshambaugh merged 6 commits intomatplotlib:mainfrom
i-jey:bihistogram_example
Conversation
Contributor
|
I think this example is well done and useful! Only suggestion is that I think it would make more sense visually when comparing datasets like this to have a constant bin width rather than constant number of bins, and share them between the datasets. For example: bin_width = 0.25
bins = np.arange(np.min([dataset1, dataset2]), np.max([dataset1, dataset2]) + bin_width, bin_width)
ax.hist(dataset1, bins=bins, label="Dataset 1") |
Contributor
Author
|
That's a good catch, totally agree. I've added that in, thanks for taking a look! |
scottshambaugh
approved these changes
Oct 24, 2023
Contributor
|
The built docs look good to me. |
Contributor
|
@i-jey thanks and congratulations on your first contribution to Matplotlib! 🎉 We hope to see you again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


PR summary
Adds an example to the documentation for plotting a bihistogram (see the closed PR #27180 for prior discussion)
PR checklist