Skip to content

Fix get_path for 3d artists#27440

Merged
ksunden merged 1 commit intomatplotlib:mainfrom
thrien:fix_path2d
Dec 4, 2023
Merged

Fix get_path for 3d artists#27440
ksunden merged 1 commit intomatplotlib:mainfrom
thrien:fix_path2d

Conversation

@thrien
Copy link
Copy Markdown

@thrien thrien commented Dec 4, 2023

closes #27361

PR summary

The solution is a slightly adapted version of 1868c05 as was suggested by the author @oscargus.

I've added a test for the specific issue which now passes.

PR checklist

This is a slightly adapted version of commit
1868c05
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@thrien thrien marked this pull request as ready for review December 4, 2023 19:24
@oscargus oscargus added this to the v3.9.0 milestone Dec 4, 2023
@ksunden ksunden merged commit 2cd4a40 into matplotlib:main Dec 4, 2023
@ksunden
Copy link
Copy Markdown
Member

ksunden commented Dec 4, 2023

Thank you @thrien, congrats on your first merged PR here. Hope to hear from you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: (Tight) layout engine breaks for 3D patches

3 participants